the configuration template asked for a document that did not exist

$G_tos_vers stayed at "1.2" while the documents in Obj/doc/ were renamed
twice, in 2014 and in 2015, up to 1.4: the last time the two values were
aligned was in 2013.

The effect on a fresh installation: file_get_contents does not find the file,
writes a warning in the log and returns FALSE, and the user is asked to accept
an empty document anyway.

Checked in the container with 1.2 and with 1.4, everything else being equal:
with 1.2 the dialog arrives with no text and the warning is in the log, with
1.4 the text of the document arrives and the log is clean.

The switchover dates ($G_tos_dthard and $G_tos_dtsoft, november 2013) are left
as they are: they are in the past, so on a fresh installation the current
document has to be accepted right away, which is the intended behaviour.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014M1jiEq9cHdE5SE5j6vFuE

diff --git a/web/Obj/brisk.conf-templ.pho b/web/Obj/brisk.conf-templ.pho
index f2486fdc6ff7581a4bfa181dd70385e431b787f4..3bd7563de75cb352231606cb0d0c5a36225cbb6b 100644 (file)
--- a/web/Obj/brisk.conf-templ.pho
+++ b/web/Obj/brisk.conf-templ.pho
@@ -121,7 +121,12 @@ $G_btrace_pref_sub = "/home/nastasi/web/";
 $G_doc_path = "Obj/doc/";
 
 // licence related stuff
-$G_tos_vers = "1.2";
+// The version must match a document present in $G_doc_path: the file is
+// looked for as <doc_path>/<G_tos_fname> with version and language. Since
+// 2014 the documents were renamed twice (1.2 -> 1.3 -> 1.4) without updating
+// this: a fresh installation looked for a file that did not exist and showed
+// the users an empty document to accept.
+$G_tos_vers = "1.4";
 $G_tos_fname = "terms-of-service_V%s_%s.txt";
 // USE date +%s -d 'Wed Nov 20 18:35:41 CET 2013' to calculate
 $G_tos_dthard = 1384968941;