G_false reference and all explicit pass by references removed

[brisk.git] / web / briskin5 / Obj / placing.phh

diff --git a/web/briskin5/Obj/placing.phh b/web/briskin5/Obj/placing.phh
index 5e1144a..d6d6547 100644 (file)
--- a/web/briskin5/Obj/placing.phh
+++ b/web/briskin5/Obj/placing.phh
@@ -49,7 +49,7 @@ class Ptsgam {
     $this->gam = $gam;
   }
 
-  function &myclone()
+  function myclone()
   {
     $ret = new Ptsgam($this->username, $this->pts, $this->gam);
 
@@ -142,8 +142,11 @@ function placing_time_file()
 function placing_time_pgsql()
 {    
     GLOBAL $G_dbpfx;
-    // FIXME: now create can return FALSE
-    $bdb = BriskDB::create();
+    
+    if (($bdb = BriskDB::create()) == FALSE) {
+        log_crit("placing: database connection failed");
+        return (FALSE);
+    }
     
     $mti_sql = sprintf("SELECT CAST(EXTRACT(EPOCH FROM mtime) AS INTEGER) as mtime 
                         FROM %sbin5_places_mtime WHERE code = 0;", $G_dbpfx);
@@ -174,7 +177,7 @@ function placing_date($mtime)
 }
   
 
-function placing_show_file(&$user, $ty, $subty) 
+function placing_show_file($user, $ty, $subty) 
 {
   $tail = FALSE;
 
@@ -252,8 +255,10 @@ function placing_show_pgsql(&$user, $ty, $subty)
 {
     GLOBAL $G_dbpfx;
     
-    // FIXME: now create can return FALSE
-    $bdb = BriskDB::create();
+    if (($bdb = BriskDB::create()) == FALSE) {
+        log_crit("placing: database connection failed");
+        return ("");
+    }
       
     if ($user != FALSE) {
         $pla_sql = sprintf("SELECT * from %sbin5_places where type = %d AND (rank <= %d OR ucode = '%s');",